fix: run CI on main in addition to master - #9
Merged
Conversation
The GitHub Actions CI workflow only triggered on push/PR to `master`, but `main` is the repo's actual default branch (confirmed via `gh repo view --json defaultBranchRef`). PRs targeting `main` — like the one that just merged the migration state tracking feature — got no CI run at all. Adds `main` to the trigger branches alongside `master` and documents the finding in CI_NOTES.md, including that `main` still lacks the branch protection rule that `master` has (a separate repo-settings change, not covered here). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlonly triggered on push/PR tomaster, butmainis the repo's actual default branch (gh repo view --json defaultBranchRefconfirms this) — PRs targetingmaingot no CI run at all, which is why PR Add migration state tracking (--status, --history, --promote, --record-rollback) #8 merged with no checks.mainalongsidemasterto the trigger list so both are covered during the transition..github/CI_NOTES.md, including thatmainstill has no branch protection rule whilemasterhas one with 13 required status checks — that's a separate repo-settings change (not a workflow file change) and hasn't been done yet.Test plan
python -c "import yaml; yaml.safe_load(open('.github/workflows/ci.yml'))"— valid YAMLgrep -rn master .github/workflows/*.yml— only the intendedci.ymltrigger lines remain;cd.ymlis tag-triggered and unaffectedCIworkflow actually fires on this PR (since it now targetsmain)🤖 Generated with Claude Code